RE: [PATCH net-next 5/6] be2net: move async cmd processing to a separate routine
From: Sathya Perla <hidden>
Date: 2014-05-30 09:18:40
-----Original Message----- From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On Behalf Of Sathya Perla
...
quoted hunk ↗ jump to hunk
static int be_mcc_compl_process(struct be_adapter *adapter, struct be_mcc_compl *compl) { enum mcc_base_status base_status; enum mcc_addl_status addl_status; struct be_cmd_resp_hdr *resp_hdr; - u8 opcode = 0, subsystem = 0; + u8 opcode, subsystem; /* Just swap the status to host endian; mcc tag is opaquely copied * from mcc_wrb */@@ -148,45 +196,13 @@ static int be_mcc_compl_process(struct be_adapter*adapter, addl_status = addl_status(compl->status); resp_hdr = be_decode_resp_hdr(compl->tag0, compl->tag1); + opcode = resp_hdr->opcode; + subsystem = resp_hdr->subsystem; - if (resp_hdr) { - opcode = resp_hdr->opcode; - subsystem = resp_hdr->subsystem; - } -
I missed a NULL check here. I'll fix this up and re-send the patch set. Thanks!
-- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html