Re: [PATCH net-next] bridge: fix the unbalanced promiscuous count when add_if failed
From: Amos Kong <hidden>
Date: 2014-05-29 03:51:42
Also in:
bridge
On Thu, May 29, 2014 at 10:15:30AM +0800, Wang Weidong wrote:
quoted hunk ↗ jump to hunk
As commit 2796d0c648c94("bridge: Automatically manage port promiscuous mode."), make the add_if use dev_set_allmulti instead of dev_set_promiscuous, so when add_if failed, we should do dev_set_allmulti(dev, -1). Signed-off-by: Wang Weidong <redacted> --- net/bridge/br_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 104a811..a08d2b8 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c@@ -528,7 +528,7 @@ err2: kobject_put(&p->kobj); p = NULL; /* kobject_put frees */ err1: - dev_set_promiscuity(dev, -1); + dev_set_allmulti(dev, -1);
Right fix. Reviewed-by: Amos Kong <redacted>
put_back: dev_put(dev); kfree(p); -- 1.8.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Amos.