Re: [PATCH net-next 1/2] net/mlx4_core: Deprecate use_prio module parameter

On 5/26/2014 10:22 PM, Ben Hutchings wrote:

On Mon, 2014-05-19 at 11:37 +0300, Amir Vadai wrote:

quoted

It was used for steering by user priority for A0 steering. A0 mode is
not supported anymore. Printing a message and ignoring the parameter.

CC: Carol Soto <redacted>
Signed-off-by: Amir Vadai <redacted>
---
  drivers/net/ethernet/mellanox/mlx4/main.c | 8 ++++----
  include/linux/mlx4/device.h               | 1 -
  2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
index a56f601..08ff5dd 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c

@@ -132,8 +132,7 @@ MODULE_PARM_DESC(log_num_vlan, "Log2 max number of VLANs per ETH port (0-7)");

  static bool use_prio;
  module_param_named(use_prio, use_prio, bool, 0444);

Perhaps the sysfs permissions should be set to 0 (i.e. not visible in
sysfs)?

Good idea - since the series already applied, will send another patch.

[...]

quoted

+	if (use_prio != 0)
+		pr_warn("mlx4_core: use_prio - obsolete module param, ignored\n");

You spell it pr_warning() in the adjacent logging statements.

Patch 2/2 "net/mlx4_core: Replace pr_warning() with pr_warn()" in this patch series will take care to the other pr_warning's

Thanks,
Amir

Ben.