Re: [net-next 02/11] ixgbe: clean up checkpatch warnings about CODE_INDENT and LEADING_SPACE
flat view
From: Joe Perches <joe@perches.com>
Date: 2014-05-14 16:26:03
On Wed, 2014-05-14 at 01:54 -0700, Jeff Kirsher wrote: trivial note:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
[]
quoted hunk ↗ jump to hunk
@@ -362,7 +362,7 @@ struct ixgbe_ring_container { for (pos = (head).ring; pos != NULL; pos = pos->next) #define MAX_RX_PACKET_BUFFERS ((adapter->flags & IXGBE_FLAG_DCB_ENABLED) \ - ? 8 : 1) + ? 8 : 1)
My preference would be to use a form that keeps the actual statement on a single line like: #define MAX_RX_PACKET_BUFFERS \ (adapter->flags & IXGBE_FLAG_DCB_ENABLED ? 8 : 1) or if you really like parentheses #define MAX_RX_PACKET_BUFFERS \ ((adapter->flags & IXGBE_FLAG_DCB_ENABLED) ? 8 : 1)