Re: [Linux-zigbee-devel] [PATCH net-next 4/6] 6lowpan: fix fragmentation

On Wed, 14 May 2014 17:56:57 +0200
Alexander Aring [off-list ref] wrote:

quoted

+
+	frag = alloc_skb(real_dev->hard_header_len +
+			 real_dev->needed_tailroom + size,
+			 GFP_ATOMIC);

Why not keep netdev_alloc_skb for the real_dev?

But then we need to use dev_kfree_skb.

Because netdev_alloc_skb allocates "for RX", which uses different
allocation flags internally and might do the wrong thing when memory
is tight.

Also, all skb free funtions are essentially the same, where
dev_kfree_skb == kfree_skb by a macro definition, and what remains
differs pretty much only in how it shows up in traces. They all call
__kfree_skb internally.

- Alex