Re: [PATCH net,stable v2] net: cdc_mbim: __vlan_find_dev_deep need rcu_read_lock

From: Bjørn Mork <redacted>
Date: Sat,  3 May 2014 16:12:47 +0200

Fixes this warning introduced by commit 5b8f15f78e6f
("net: cdc_mbim: handle IPv6 Neigbor Solicitations"):

===============================
[ INFO: suspicious RCU usage. ]
3.15.0-rc3 #213 Tainted: G        W  O
-------------------------------
net/8021q/vlan_core.c:69 suspicious rcu_dereference_check() usage!

other info that might help us debug this:

rcu_scheduler_active = 1, debug_locks = 1
no locks held by ksoftirqd/0/3.

 ...

Fixes: 5b8f15f78e6f ("net: cdc_mbim: handle IPv6 Neigbor Solicitations")
Signed-off-by: Bjørn Mork <redacted>
---
v2: get a ref to the netdev before releasing the lock.  Thanks to Eric Dumazet

Please add this to the stable v3.13 and v3.14 queues as well.  Thanks.

Applied, thanks a lot.

If someone feels slightly inspired it might be a good idea to rename
__vlan_find_dev_deep to __vlan_find_dev_deep_rcu.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html