Re: [PATCH 0/8 v4] net: Checksum offload changes
From: David Miller <davem@davemloft.net>
Date: 2014-05-05 19:29:45
From: Tom Herbert <redacted> Date: Fri, 2 May 2014 16:27:44 -0700 (PDT)
I am working on overhauling RX checksum offload. Goals of this effort
are:
- Specify what exactly it means when driver returns CHECKSUM_UNNECESSARY
- Preserve CHECKSUM_COMPLETE through encapsulation layers
- Don't do skb_checksum more than once per packet
- Unify GRO and non-GRO csum verification as much as possible
- Unify the checksum functions (checksum_init)
- Simply code
What is in this first patch set:
- Create a common "checksum_init" function which is called from
TCPv{4,6} and UDPv{4,6}
- Add some for RFC6936, UDP/IPv6 zero checksums
- Add architecture support for csum_add and provide implementations
for x86_64 and Sparc 32 and 64 bit (please test the latter)
Please review carefully and test if possible, mucking with basic
checksum functions is always a little precarious :-)This looks really good to me, thanks for integrating all the feedback and following up. Series applied to net-next, thanks.