-----Original Message-----
From: Sucheta Chakraborty
Sent: Monday, April 28, 2014 2:40 PM
To: 'Stephen Hemminger'
Cc: netdev; Dept-HSG Linux NIC Dev; ben@decadent.org.uk;
gregory.v.rose@intel.com; linux-net-drivers@solarflare.com; Ariel
Elior; amirv@mellanox.com; mkubecek@suse.cz
Subject: RE: [PATCH 1/1] iproute2: v3: Add support to configure SR-IOV
VF minimum and maximum Tx rate through ip tool.

quoted

-----Original Message-----
From: Stephen Hemminger [mailto:stephen@networkplumber.org]
Sent: Wednesday, April 23, 2014 4:11 AM
To: Sucheta Chakraborty
Cc: netdev; Dept-HSG Linux NIC Dev; ben@decadent.org.uk;
gregory.v.rose@intel.com; linux-net-drivers@solarflare.com; Ariel
Elior; amirv@mellanox.com; mkubecek@suse.cz
Subject: Re: [PATCH 1/1] iproute2: v3: Add support to configure SR-

IOV

quoted

VF minimum and maximum Tx rate through ip tool.

On Mon, 14 Apr 2014 00:37:00 -0400
Sucheta Chakraborty [off-list ref] wrote:

quoted

o "min_tx_rate" option has been added for minimum Tx rate. Hence,

for

quoted

quoted

  consistent naming, "max_tx_rate" option has been introduced for

maximum

quoted

  Tx rate.

o Change in v2: "rate" can be used along with "max_tx_rate".
  When both are specified, "max_tx_rate" should override.

o Change in v3:
  * IFLA_VF_RATE: When IFLA_VF_RATE is used, and user has given

only

quoted

one of

quoted

    min_tx_rate or max_tx_rate, reading of previous rate limits is

done in

quoted

    userspace instead of in kernel space before ndo_set_vf_rate.

  * IFLA_VF_TX_RATE: When IFLA_VF_TX_RATE is used, min_tx_rate is

always read

quoted

    in kernel space. This takes care of below scenarios:
    (1) when old tool sends "rate" but kernel is new (expects min
and

max)

quoted

    (2) when new tool sends only "rate" but kernel is old (expects
only "rate")

Signed-off-by: Sucheta Chakraborty <redacted>

I like the concept fine, but the general policy of ip route commands
is that the output format should match the input (except for

statistics).

quoted

This (and ther earlier tx_rate patch are printing values in a
different format than the input

i.e don't print:
	max tx rate 110 (Mbps)
instead print:
	max_tx_rate 110Mbps

With this change display would be as below:

vf 0 MAC 3e:a0:ca:bd:ae:5a, tx rate 300 (Mbps), max_tx_rate 300Mbps,
    min_tx_rate 200Mbps

I did not change tx rate option to maintain backward compatibility.

Is the output valid?

Thanks,
Sucheta.

Hi Stephen,

Did you get a chance to look at my previous mail? Does the above output looks okay to you?

Thanks,
Sucheta.