On Thu, May 1, 2014 at 3:55 AM, Daniel Borkmann [off-list ref] wrote:

quoted

[ Chema, please also keep me in cc if possible. ]

Done.

quoted

Looks good to me. For casting pointers as Dave noted recently, please
use 'unsigned long'. This needs to be fixed in other places as well.

Done.

Ohh, and please in future include net or net-next into your subject line.

Done.

On Wed, Apr 30, 2014 at 3:21 PM, Alexei Starovoitov [off-list ref] wrote:

quoted

+static u64 __skb_get_tra_offset(u64 ctx, u64 A, u64 X, u64 r4, u64 r5)
+{
+       struct flow_keys keys;
+       struct sk_buff *skb = (struct sk_buff *)(long) ctx;

I think kernel style recommends to swap above two lines,
but that's a nit.

Done.

-Chema