[PATCH] veth: Allow a peer to be up at creation time
From: Kusanagi Kouichi <hidden>
Date: 2014-04-24 09:05:27
Also in:
lkml
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Currently, a veth peer cannot be up at creation time. # ip link add type veth peer up RTNETLINK answers: Transport endpoint is not connected Signed-off-by: Kusanagi Kouichi <redacted> --- drivers/net/veth.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index b4a10bc..aa87afc 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c@@ -373,10 +373,6 @@ static int veth_newlink(struct net *src_net, struct net_device *dev, netif_carrier_off(peer); - err = rtnl_configure_link(peer, ifmp); - if (err < 0) - goto err_configure_peer; - /* * register dev last *
@@ -407,11 +403,16 @@ static int veth_newlink(struct net *src_net, struct net_device *dev, priv = netdev_priv(peer); rcu_assign_pointer(priv->peer, dev); + + err = rtnl_configure_link(peer, ifmp); + if (err < 0) + goto err_configure_peer; + return 0; -err_register_dev: - /* nothing to do */ err_configure_peer: + unregister_netdevice(dev); +err_register_dev: unregister_netdevice(peer); return err;
--
2.0.0.rc0