Re: [PATCH net-next V4 6/9] Altera TSE: Add main and header file for Altera Ethernet Driver

Hi Joe,

On Wed, Mar 12, 2014 at 3:42 PM, Joe Perches [off-list ref] wrote:

On Wed, 2014-03-12 at 15:15 -0500, Vince Bridgers wrote:

quoted

This patch adds the main driver and header file for the Altera Triple
Speed Ethernet driver.

[]

quoted

diff --git a/drivers/net/ethernet/altera/altera_tse.h b/drivers/net/ethernet/altera/altera_tse.h

[]

quoted

+/* MAC register Space. Note that some of these registers may or may not be
+ * present depending upon options chosen by the user when the core was
+ * configured and built. Please consult the Altera Triple Speed Ethernet User
+ * Guide for details.
+ */
+struct altera_tse_mac {
+     /* Bits 15:0: MegaCore function revision (0x0800). Bit 31:16: Customer
+      * specific revision
+      */
+     unsigned int megacore_revision;
+     /* Provides a memory location for user applications to test the device
+      * memory operation.
+      */
+     unsigned int scratch_pad;
+     /* The host processor uses this register to control and configure the
+      * MAC block
+      */
+     unsigned int command_config;
+     /* 32-bit primary MAC address word 0 bits 0 to 31 of the primary
+      * MAC address
+      */
+     unsigned int mac_addr_0;
+     /* 32-bit primary MAC address word 1 bits 32 to 47 of the primary
+      * MAC address
+      */

maybe all of these should be specifically sized using u32 like

        u32 mac_addr_0;

yes, I agree - that would be better. I'll pick this up in V5.

Cheers,

Vince