Re: [PATCH net-next v3 5/9] Altera TSE: Add Miscellaneous Files for Altera Ethernet Driver

Hi Joe,

On Tue, Mar 11, 2014 at 5:59 PM, Joe Perches [off-list ref] wrote:

On Tue, 2014-03-11 at 17:43 -0500, Vince Bridgers wrote:

quoted

This patch adds miscellaneous files for the Altera Ethernet Driver,
including ethtool support.

trivial notes:

quoted

diff --git a/drivers/net/ethernet/altera/altera_tse_ethtool.c b/drivers/net/ethernet/altera/altera_tse_ethtool.c

[]

quoted

+static char const stat_gstrings[][ETH_GSTRING_LEN] = {

static const char

quoted

+     "aFramesTransmittedOK",

Why the prefix with a?

These names follow the names of the statistics found in the databook
for the Altera Triple Speed Ethernet (TSE) soft IP. I'm not
emotionally attached to these names, so will review the statistics
names and follow common usage instead. Thank you for noticing and
commenting.

quoted

+     "aFramesReceivedOK",

"rx_packets" is typically used

quoted

+     "aFramesCheckSequenceErrors",

quoted

+     "aAlignmentErrors",
+     "aOctetsTransmittedOK",
+     "aOctetsReceivedOK",
+     "aTxPAUSEMACCtrlFrames",
+     "aRxPAUSEMACCtrlFrames",
+     "ifInErrors",
+     "ifOutErrors",
+     "ifInUcastPkts",
+     "ifInMulticastPkts",
+     "ifInBroadcastPkts",
+     "ifOutDiscards",
+     "ifOutUcastPkts",
+     "ifOutMulticastPkts",
+     "ifOutBroadcastPkts",
+     "etherStatsDropEvents",
+     "etherStatsOctets",
+     "etherStatsPkts",
+     "etherStatsUndersizePkts",
+     "etherStatsOversizePkts",
+     "etherStatsPkts64Octets",
+     "etherStatsPkts65to127Octets",
+     "etherStatsPkts128to255Octets",
+     "etherStatsPkts256to511Octets",
+     "etherStatsPkts512to1023Octets",
+     "etherStatsPkts1024to1518Octets",
+     "etherStatsPkts1519toXOctets",
+     "etherStatsJabbers",
+     "etherStatsFragments",

Perhaps review all of these strings for
unusual naming.

Will do, thanks.

quoted

+static void tse_get_regs(struct net_device *dev, struct ethtool_regs *regs,
+                      void *regbuf)
+{
+     int i;
+     struct altera_tse_private *priv = netdev_priv(dev);
+     u32 *tse_mac_regs = (u32 *)priv->mac_dev;
+     u32 *buf = (u32 *)regbuf;

void * doesn't need a cast

        u32 *buf = regbuf

is just fine.

I'll pick this up while reviewing and updating the stats names.

Thank you for taking the time to review and provide constructive
comments. I'll address these and respin.

All the best,

Vince
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html