Re: [PATCH v2] mac80211: LLVMLinux: Remove VLAIS usage from mac80211

On 9. März 2014 00:00:19 MEZ, Sergei Antonov [off-list ref] wrote:

On 8 March 2014 23:01, PaX Team [off-list ref] wrote:

quoted

On 8 Mar 2014 at 21:29, Sergei Antonov wrote:

quoted

quoted

-       memset(&aead_req, 0, sizeof(aead_req));
+       char aead_req_data[sizeof(struct aead_request) +
+                               crypto_aead_reqsize(tfm) +
+                               CRYPTO_MINALIGN]

CRYPTO_MINALIGN_ATTR;

quoted

^^^^^^^^^^^^^^^^^^^^

quoted

wouldn't the underlined attribute ensure the required alignment?

Yes. Sorry, I overlooked it.

I would remove unneeded CRYPTO_MINALIGN and get the alignment from the
target structure:
       char aead_req_data[sizeof(struct aead_request) +
                          crypto_aead_reqsize(tfm)]
       __attribute__((__aligned__(__alignof__(struct aead_request))));

LGTM



-- 
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html