Thread (4 messages) 4 messages, 2 authors, 2014-04-01

RE: [PATCH net-next] qlcnic: Fix build failure due to undefined reference to `vxlan_get_rx_port'

From: Shahed Shaikh <hidden>
Date: 2014-03-31 23:33:49

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Tuesday, April 01, 2014 2:00 AM
To: Shahed Shaikh
Cc: netdev; Dept-HSG Linux NIC Dev
Subject: Re: [PATCH net-next] qlcnic: Fix build failure due to undefined
reference to `vxlan_get_rx_port'

From: Shahed Shaikh <redacted>
Date: Sun, 30 Mar 2014 10:42:25 -0400
quoted
From: Shahed Shaikh <redacted>

Commit 2b3d7b758c687("qlcnic: Add VXLAN Rx offload support") uses
vxlan_get_rx_port() which caused build failure when VXLAN=m.

This patch fixes the build failure by adding dependency on VXLAN in
Kconfig of qlcnic module and use vxlan_get_rx_port() accordingly.

Signed-off-by: Shahed Shaikh <redacted>
---
Hi David,

Please apply this patch to net-next.
Do this properly, don't just CPP protect the symbol that fails.

Look at how I40E_VXLAN is used, it protect everything from the
ndo_*() ops to the surrounding support code.
Hi David,

Looks like net-next is closed. Please let me know if I can send the revised version of this patch as per your suggestion.

Thanks,
Shahed
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help