Re: [PATCH net-next] net-gro: restore frag0 optimization
From: Eric Dumazet <hidden>
Date: 2014-03-31 21:19:46
On Mon, 2014-03-31 at 14:01 -0700, Eric Dumazet wrote:
BTW, I found a off-by-one error in skb_gro_header_hard()
-static inline int skb_gro_header_hard(struct sk_buff *skb, unsigned int hlen)
+static inline bool skb_gro_header_hard(const struct sk_buff *skb,
+ unsigned int hlen)
{
- return NAPI_GRO_CB(skb)->frag0_len < hlen;
+ return NAPI_GRO_CB(skb)->frag0_len <= hlen;
}Oh well, scratch this. This strange function name fooled me again. bool slowpath = hlen > NAPI_GRO_CB(skb)->frag0_len;