Re: [PATCH] net: fec: make sure to init MAC address
From: David Miller <davem@davemloft.net>
Date: 2014-03-29 22:54:30
From: Lucas Stach <dev@lynxeye.de> Date: Sat, 29 Mar 2014 00:19:24 +0100
quoted hunk ↗ jump to hunk
@@ -1898,10 +1898,11 @@ fec_set_mac_address(struct net_device *ndev, void *p) struct fec_enet_private *fep = netdev_priv(ndev); struct sockaddr *addr = p; - if (!is_valid_ether_addr(addr->sa_data)) - return -EADDRNOTAVAIL; - - memcpy(ndev->dev_addr, addr->sa_data, ndev->addr_len); + if (p) { + if (!is_valid_ether_addr(addr->sa_data)) + return -EADDRNOTAVAIL; + memcpy(ndev->dev_addr, addr->sa_data, ndev->addr_len); + }
This test looks awkward, if we're going to dereference and use 'addr', then test 'addr' instead of 'p'. Thanks.