Re: [PATCH net-next] tcp: generalize MAX_TCP_HEADER usage
From: Eric Dumazet <hidden>
Date: 2014-03-29 22:47:29
From: Eric Dumazet <hidden>
Date: 2014-03-29 22:47:29
On Sat, 2014-03-29 at 17:56 -0400, David Miller wrote:
From: Eric Dumazet <redacted> Date: Thu, 27 Mar 2014 13:19:06 -0700quoted
(Note that sk_stream_alloc_skb() uses MAX_TCP_HEADER anyway...)But only after your changes. Please make this clear in the commit message, I had to go check to see if there were in fact MAX_TCP_HEADER uses in sk_stream_alloc_skb in the current tree.
Yeah, lets leave sk_stream_alloc_skb() as it is (even it is only used by TCP). What I meant is that sk_stream_alloc_skb() uses MAX_TCP_HEADER (for TCP), so tcp_xmit_size_goal() should not be picky.