Thread (1 message) 1 message, 1 author, 2014-03-28

Re: [PATCH net v2] openvswitch: fix a possible deadlock and lockdep warning

From: David Miller <hidden>
Date: 2014-03-28 20:42:42

From: Flavio Leitner <redacted>
Date: Thu, 27 Mar 2014 11:05:34 -0300
There are two problematic situations.

A deadlock can happen when is_percpu is false because it can get
interrupted while holding the spinlock. Then it executes
ovs_flow_stats_update() in softirq context which tries to get
the same lock.

The second sitation is that when is_percpu is true, the code
correctly disables BH but only for the local CPU, so the
following can happen when locking the remote CPU without
disabling BH:
 ...
Signed-off-by: Flavio Leitner <redacted>
---
 v2: better commit message
Ok, I just saw Jesse's request that I apply this directly, so I
have done so.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help