Thread (1 message) 1 message, 1 author, 2014-03-28

Re: [PATCH net] openvswitch: fix a possible deadlock and lockdep warning

From: David Miller <hidden>
Date: 2014-03-28 20:36:39

From: Flavio Leitner <redacted>
Date: Thu, 27 Mar 2014 09:53:56 -0300
There are two problematic situations.

A deadlock can happen when is_percpu is false because it can get
interrupted while holding the spinlock. Then it executes
ovs_flow_stats_update() in softirq context which tries to get
the same lock.

The second sitation is that when is_percpu is true, the code
correctly disables BH only for the local CPU, but that confuses
lockdep enough to trigger the warning below.

This patch disables BH for both cases fixing the real deadlock
and the lockdep warning message.
 ...
Signed-off-by: Flavio Leitner <redacted>
I'll let Jesse review and pick this up.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help