Thread (20 messages) 20 messages, 2 authors, 2014-03-19

Re: [net-next v2 02/15] i40evf: correctly program RSS HLUT table

flat view

From: David Miller <davem@davemloft.net>
Date: 2014-03-19 18:07:53

From: Jeff Kirsher <redacted>
Date: Tue, 18 Mar 2014 20:42:00 -0700
+#define NEXT_QUEUE(_j) (++_j >= adapter->vsi_res->num_queue_pairs ? _j = 0 : _j)
I would strong recommend breaking the increment out of the test
and using a function rather than a macro:

static int next_queue(struct i40evf_adapter *adapter, int j)
{
	j += 1;

	return j >= adapter->vsi_res->num_queue_pairs ? 0 : j;
}

 ..

	j = next_queue(adapter, j);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help