[PATCH net-next] pkt_sched: add cond_resched() to class and qdisc dump
From: Eric Dumazet <hidden>
Date: 2014-03-08 02:01:06
Subsystem:
networking [general], tc subsystem, the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jamal Hadi Salim, Jiri Pirko, Linus Torvalds
From: Eric Dumazet <edumazet@google.com> We have seen delays of more than 50ms in class or qdisc dumps, in case device is under high TX stress. Add cond_resched() to give a chance to higher prio tasks to get cpu. Signed-off-by: Eric Dumazet <edumazet@google.com> --- Google-Bug-Id: 13317737 net/sched/sch_api.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index 1313145e3b86..15974e38cada 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c@@ -1303,6 +1303,7 @@ static int tc_fill_qdisc(struct sk_buff *skb, struct Qdisc *q, u32 clid, struct gnet_dump d; struct qdisc_size_table *stab; + cond_resched(); nlh = nlmsg_put(skb, portid, seq, event, sizeof(*tcm), flags); if (!nlh) goto out_nlmsg_trim;
@@ -1617,6 +1618,7 @@ static int tc_fill_tclass(struct sk_buff *skb, struct Qdisc *q, struct gnet_dump d; const struct Qdisc_class_ops *cl_ops = q->ops->cl_ops; + cond_resched(); nlh = nlmsg_put(skb, portid, seq, event, sizeof(*tcm), flags); if (!nlh) goto out_nlmsg_trim;