Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq

On Thursday, March 6, 2014, David Miller [off-list ref] wrote:

From: Christian Riesch <christian.riesch-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org <javascript:;>>
Date: Wed, 5 Mar 2014 11:25:28 +0100

quoted

@@ -1641,7 +1640,15 @@ static int emac_dev_open(struct net_device *ndev)

 rollback:

-     dev_err(emac_dev, "DaVinci EMAC: devm_request_irq() failed");
+     dev_err(emac_dev, "DaVinci EMAC: request_irq() failed");
+
+     for (q = k; k >= 0; k--) {
+             for (m = i; m >= res->start; m--)
+                     free_irq(m, ndev);
+             res = platform_get_resource(priv->pdev, IORESOURCE_IRQ,

k-1);

quoted

+             m = res->end;
+     }

This final assignment in the loop of 'm' is unused?

The inner for() loop always started with "m = i;"

This should probably read

i = res->end;

I just took the old code, without thinking about it. Thanks for catching it.

Christian