Re: [PATCH net-next] chelsio: Use more current logging style

On Thu, 2014-03-06 at 11:50 +0530, Hariprasad S wrote:

On Tue, Mar 04, 2014 at 11:36:45 -0800, Joe Perches wrote:

quoted

On Tue, 2014-03-04 at 23:22 +0300, Sergei Shtylyov wrote:

quoted

On 03/04/2014 08:43 PM, Joe Perches wrote:

quoted

quoted

From: Kumar Sanghvi <redacted>
+		CH_WARN(adap, "SGE idma%u, queue%u, maybe stuck state%u %dsecs"
+			" (debug0=%#x, debug11=%#x)\n",

Probably better with the format coalesced:
		CH_WARN(adap, "SGE idma%u, queue%u, maybe stuck state%u %dsecs (debug0=%#x, debug11=%#x)\n",

    Surely better, as otherwise it shouldn't pass scripts/checkpatch.pl.

It'd complain in any case as CH_<LEVEL> macros are 
uppercase and checkpatch doesn't know that those are
logging uses.

Maybe renaming all the CH_<LEVEL> macros to lower
case like this would help.

This also can now use dynamic_debug for the ch_dbg
statements and removes the CH_MSG function as it's
unused.

From: Joe Perches <joe@perches.com>

Use more standard style lower case logging macros.

Coalesce formats
Remove unnecessary periods
Enable dynamic debugging and verify debug format/arguments

Signed-off-by: Joe Perches <joe@perches.com>
---

[...] 

quoted

I don't see this patch in net-next or in the netdev patchwork queue.
Is the patch lost by any chance? Or I missed something ?

Maybe an ack by someone from Chelsio?

Likely David thought it RFC because of the ongoing
patches from Chelsio with "changes requested".

http://patchwork.ozlabs.org/patch/326462/

It's a trivial bit of code to redo if necessary or
desired after the larger patch set done by you all.

cheers, Joe