Re: [PATCHv2 net-next 16/31] iw_cxgb4: don't leak skb in c4iw_uld_rx_handler().
From: Sergei Shtylyov <hidden>
Date: 2014-03-03 18:46:39
Also in:
linux-rdma
Hello. On 03/03/2014 09:41 AM, Hariprasad Shenai wrote:
From: Steve Wise <redacted>
Signed-off-by: Steve Wise <redacted> --- drivers/infiniband/hw/cxgb4/device.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
quoted hunk
diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c index 9542ccc..f73fea4 100644 --- a/drivers/infiniband/hw/cxgb4/device.c +++ b/drivers/infiniband/hw/cxgb4/device.c@@ -936,9 +936,11 @@ static int c4iw_uld_rx_handler(void *handle, const __be64 *rsp, opcode = *(u8 *)rsp; if (c4iw_handlers[opcode]) c4iw_handlers[opcode](dev, skb); - else + else { pr_info("%s no handler opcode 0x%x...\n", __func__, opcode); + kfree_skb(skb); + }
Should have {} in both arms of the *if* statement now. See
Documentation/CodingStyle.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html