Re: [PATCH net-next 01/10] net: phy: add "internal" PHY mode
From: Sergei Shtylyov <hidden>
Date: 2014-02-12 14:35:00
Also in:
linux-devicetree
Hello. On 12-02-2014 8:07, Florian Fainelli wrote:
On some systems, the PHY can be internal, in the same package as the Ethernet MAC, and still be responding to a specific address on the MDIO bus, in that case, the Ethernet MAC might need to know about it to properly configure a port multiplexer to switch to an internal or external PHY. Add a new PHY interface mode for this and update the Device Tree of_get_phy_mode() function to look for it.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
[...]
quoted hunk ↗ jump to hunk
@@ -553,7 +554,8 @@ static inline bool phy_interrupt_is_valid(struct phy_device *phydev) */ static inline bool phy_is_internal(struct phy_device *phydev) { - return phydev->is_internal; + return phydev->is_internal || + phydev->interface == PHY_INTERFACE_MODE_INTERNAL;
Shouldn't the continuation line be aligned under 'phydev' on the borken up
line)?
WBR, Sergei