Re: [PATCH net-next 1/2] dts: Add bindings for multicast hash bins and perfect filter entries

From
Giuseppe CAVALLARO <hidden>
Date
2014-02-04 09:58:21
Also in
linux-devicetree
Reply to
Vince Bridgers, 2014-01-31
Hello Vince

On 1/31/2014 9:15 PM, Vince Bridgers wrote:
This change adds bindings for the number of multicast hash bins and perfect
filter entries supported by the Synopsys EMAC. The Synopsys EMAC core is
configurable at device creation time, and can be configured for a different
number of multicast hash bins and a different number of perfect filter entries.
The device does not provide a way to query these parameters, therefore
parameters are required. The Altera Cyclone V SOC has support for 256
multicast hash bins and 128 perfect filter entries, and is different than
what's currently provided in the stmmac driver.
thanks a lot for these patches, I have just added some comment for the
patch #2

peppe
quoted hunk ↗ jump to hunk
Signed-off-by: Vince Bridgers <redacted>
---
  Documentation/devicetree/bindings/net/stmmac.txt |    6 ++++++
  1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt
index 9d92d42..dbf7498 100644
--- a/Documentation/devicetree/bindings/net/stmmac.txt
+++ b/Documentation/devicetree/bindings/net/stmmac.txt
@@ -34,6 +34,10 @@ Optional properties:
  	reset phandle is given
  - max-frame-size:	Maximum Transfer Unit (IEEE defined MTU), rather
  			than the maximum frame size.
+- snps,multicast-filter-bins:	Number of multicast filter hash bins
+				supported by this device instance
+- snps,perfect-filter-entries:	Number of perfect filter entries supported
+				by this device instance

  Examples:
@@ -46,4 +50,6 @@ Examples:
  		mac-address = [000000000000]; /* Filled in by U-Boot */
  		max-frame-size = <3800>;
  		phy-mode = "gmii";
+		snps,multicast-filter-bins = <256>;
+		snps,perfect-filter-entries = <128>;
  	};
Thread (3 messages) 3 messages, 3 authors, last reply 2014-02-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help