Thread (20 messages) 20 messages, 7 authors, 2014-03-07

Re: [PATCH 1/4] net: rfkill: gpio: remove unused and obsoleteplatform parameters

From: Marc Dietrich <marvin24@gmx.de>
Date: 2014-02-22 22:32:40
Also in: linux-wireless, lkml

On Friday 21 February 2014 16:23:49 Heikki Krogerus wrote:
Hi,

On Fri, Feb 21, 2014 at 02:55:14PM +0100, Marc Dietrich wrote:
quoted
Am Donnerstag, 20. Februar 2014, 14:51:34 schrieb Heikki Krogerus:
quoted
After upgrading to descriptor based gpios, the gpio numbers
are not used anymore. The power_clk_name and the platform
specific setup and close hooks are not used by anybody, and
we should not encourage use of such things, so removing them.
arch/arm/mach-tegra/board-paz00.c is still using platform data. Is there
some prerequisite patch I'm missing (3.14-rc3) or how can this file be
converted? We are waiting for DT support to arrive so we can finally
remove this file.
True! It still set's the shutdown_gpio and reset_gpio members. I think
I'll leave the header untouched and just clean net/rfkill/rfkill-gpio.c
in this patch. We can remove the whole header after you guys have moved
to DT.
Why? Just update the board file to remove those entries. I just checked that 
it's working fine without. So if you don't mind, add a patch to remove the 
entries as the first patch in your series.

Thanks

Marc
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help