Thread (50 messages) flat view 50 messages, 8 authors, 2014-02-22

RE: [PATCH net-next 28/35] qlcnic: Use pci_enable_msix_range() instead of pci_enable_msix()

From: Shahed Shaikh <hidden>
Date: 2014-02-22 16:18:15
Also in: linux-pci, lkml

-----Original Message-----
From: Alexander Gordeev [mailto:agordeev@redhat.com]
Sent: Saturday, February 22, 2014 2:54 PM
To: Ben Hutchings
Cc: linux-kernel; Himanshu Madhani; Rajesh Borundia; Shahed Shaikh; Dept-
Eng Linux Driver; netdev; linux-pci
Subject: Re: [PATCH net-next 28/35] qlcnic: Use pci_enable_msix_range()
instead of pci_enable_msix()

On Sat, Feb 22, 2014 at 12:48:47AM +0000, Ben Hutchings wrote:
quoted
Sorry, I'm confused and this does work.  But I wonder whether it is
really an improvement over using the old API.
Slightly, as far as I am concerned - we just exchange tri-state oddity to re-
enable MSI-X oddity. We're not going to improve drivers that can not work
with any number of MSI-Xs from a range, like this one.
I will send a patch which will make use of available MSI-X number and remove the retry logic.

Thanks,
Shahed

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help