Re: [PATCH net V2] virtio-net: alloc big buffers also when guest can receive UFO
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2014-02-21 14:52:05
Also in:
lkml, virtualization
On Fri, Feb 21, 2014 at 01:08:04PM +0800, Jason Wang wrote:
We should alloc big buffers also when guest can receive UFO pakcets to let the big packets be fit into guest rx buffer.
s/pakcets/packets/ s/be fit/fit/ otherwise: Acked-by: Michael S. Tsirkin <mst@redhat.com>
quoted hunk ↗ jump to hunk
Fixes 5c5167515d80f78f6bb538492c423adcae31ad65 (virtio-net: Allow UFO feature to be set and advertised.) Cc: Rusty Russell <redacted> Cc: Michael S. Tsirkin <mst@redhat.com> Cc: Sridhar Samudrala <redacted> Signed-off-by: Jason Wang <jasowang@redhat.com> --- Changes from V1: - tweak the commit log --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index d75f8ed..5632a99 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c@@ -1711,7 +1711,8 @@ static int virtnet_probe(struct virtio_device *vdev) /* If we can receive ANY GSO packets, we must allocate large ones. */ if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4) || virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO6) || - virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_ECN)) + virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_ECN) || + virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_UFO)) vi->big_packets = true; if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF))-- 1.8.3.2