Re: [PATCH] tcp: disable auto corking by default

Hello Eric,

quoted

Disable auto corking by default

We should let auto corking on during 3.14 development cycle so that we
can fix the bugs, and thing of some optimizations.

I agree that leaving it enabled helps to find bugs, however I'm not
happy with the round trip time degradation.

auto cork gives a strong incentive to applications to use
TCP_CORK/MSG_MORE to avoid overhead of sending multiple small
segments.

I agree. But if it breaks the application many people won't be happy,
for example I spend already 5 hours to track it down.

In the normal case, the extra delay is something like 10 us, so if an
application is really hit by this delay, its a strong sign it could be
improved, especially if auto corking is off.

Yes, but 230 micro seconds for others. :-(

Lets wait the end of 3.14 dev cycle before considering this patch.

I agree.

Btw. I mixed up the pcaps for autocork on and off, so I moved the files
that they know show what they should show.

Cheers,
        Thomas