Re: [PATCH net-next 1/2] vlan: don't allow vlan device to move between network namespaces
From: Toshiaki Makita <hidden>
Date: 2014-02-28 08:12:47
(2014/02/28 16:50), Ding Tianhong wrote:
Now the vlan device could move to another network namespace, but the read dev is sill in the old network namespace, it is unsafe and the vlan device could not work well, so don't allow to do it.
Why is this a problem? This looks like a useful feature to me. Thanks, Toshiaki Makita
quoted hunk ↗ jump to hunk
Signed-off-by: Ding Tianhong <redacted> --- net/8021q/vlan_dev.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index 566adbf..76d8fab 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c@@ -791,5 +791,8 @@ void vlan_setup(struct net_device *dev) dev->destructor = free_netdev; dev->ethtool_ops = &vlan_ethtool_ops; + /* don't allow vlan device to move between network namespaces */ + dev->features |= NETIF_F_NETNS_LOCAL; + memset(dev->broadcast, 0, ETH_ALEN); }