Thread (7 messages) 7 messages, 2 authors, 2014-02-27

Re: [PATCH net-next v5 8/8] 6lowpan: handling 6lowpan fragmentation via inet_frag api

From: Alexander Aring <alex.aring@gmail.com>
Date: 2014-02-27 21:17:00

Hi David,

On Thu, Feb 27, 2014 at 03:56:39PM -0500, David Miller wrote:
From: Alexander Aring <alex.aring@gmail.com>
Date: Thu, 27 Feb 2014 09:06:22 +0100
quoted
+static int lowpan_frag_queue(struct lowpan_frag_queue *fq,
+			     struct sk_buff *skb, const u8 frag_type,
+			     const struct ieee802154_frag_info *frag_info)
The 'frag_info' argument is unused.  You always explicitly access
mac_cb()->frag_info here.
You are absolutly right, sorry for that. I will remove this parameter
instead of using frag_info than mac_cb(skb)->frag_info... because I
compare with some other sk buffs like mac(next)->frag_info. This will be
more easier to read.

Thanks.

- Alex
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help