----- Original Message -----
From: "Nikolay Aleksandrov" <redacted>
To: netdev@vger.kernel.org
Cc: "Nikolay Aleksandrov" <redacted>, "Dave Jones" <redacted>, "Steffen Klassert" <steffen.klassert@secunet.com>, "Fan Du" <redacted>, "David S. Miller" <davem@davemloft.net>
Sent: Thursday, February 27, 2014 5:24:30 PM
Subject: Re: Possible fix

On 02/27/2014 05:17 PM, Nikolay Aleksandrov wrote:

Hi,
I'm not familiar with the code but happened to see the bug, could you
try the following patch, I believe it should fix the issue.

Thanks,
 Nik

[PATCH net] net: af_key: fix sleeping under rcu

There's a kmalloc with GFP_KERNEL in a helper
(pfkey_sadb2xfrm_user_sec_ctx) used in pfkey_compile_policy which is
called under rcu_read_lock. Adjust pfkey_sadb2xfrm_user_sec_ctx to have
a gfp argument and adjust the users.

CC: Dave Jones <redacted>
CC: Steffen Klassert <steffen.klassert@secunet.com>
CC: Fan Du <redacted>
CC: David S. Miller <davem@davemloft.net>

Signed-off-by: Nikolay Aleksandrov <redacted>
---
I'm not familiar with this code, but just happen to see the bug. I believe
this patch should take care of it.
I've left the already very long lines.

Actually there isn't a check if uctx is NULL upon return which can happen.
This is only a test patch and that check should be added as well.

Nik

Had a quick look and I think that should be okay, there isn't a need to check.

Sent from my phone