Re: [PATCH 5/5] xfrm: Fix unlink race when policies are deleted.
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2014-02-27 06:27:54
On Thu, Feb 27, 2014 at 07:16:39AM +0100, Steffen Klassert wrote:
When a policy is unlinked from the lists in thread context, the xfrm timer can fire before we can mark this policy as dead. So reinitialize the bydst hlist, then hlist_unhashed() will notice that this policy is not linked and will avoid a doulble unlink of that policy. Reported-by: Xianpeng Zhao <redacted> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
If this race condition is real then I don't see how this fix can be correct since there aren't any barriers between the check and the unlink. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt