Thread (40 messages) 40 messages, 9 authors, 2014-02-28

Re: [PATCH v4 net-next] tcp: switch rtt estimations to usec resolution

From: Eric Dumazet <hidden>
Date: 2014-02-24 22:19:28

On Mon, 2014-02-24 at 10:24 -0800, Eric Dumazet wrote:

quoted hunk ↗ jump to hunk
index d547075d8300..8e4c43d80784 100644
--- a/net/ipv4/tcp_metrics.c
+++ b/net/ipv4/tcp_metrics.c
...
-	if (crtt > tp->srtt) {
+	if (crtt > tp->srtt_us) {
 		/* Set RTO like tcp_rtt_estimator(), but from cached RTT. */
 		crtt >>= 3;
-		inet_csk(sk)->icsk_rto = crtt + max(2 * crtt, tcp_rto_min(sk));
-	} else if (tp->srtt == 0) {
This part is buggy it needs to be :

	crtt /= 8 * USEC_PER_MSEC;
	inet_csk(sk)->icsk_rto = crtt + max(2 * crtt, tcp_rto_min(sk));
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help