RE: [PATCH net 4/5] be2net: wait longer to reap TX compls in be_close()

-----Original Message-----
From: David Laight [mailto:David.Laight@ACULAB.COM]

From: Of Somnath Kotur

quoted

be_close() currently waits for a max of 200ms to receive all pending
TX compls. This timeout value was roughly calcuated based on 10G
transmission speeds and the TX queue depth. This timeout may not be
enough when the link is operating at lower speeds or in
multi-channel/SR-IOV configs with TX-rate limiting setting.
Increase the timeout to 2000ms and also bail-out if there is
a HW-error.

What about monitoring whether transmits are actually completing,
and giving up if none are completed within a suitable time period?

David, the code already does that. All the queues are checked for
any new TX compls each 1ms in the be_close()->be_tx_compl_clean()
path. This patch is not changing that logic.

thanks,
-Sathya