Re: [PATCH net-next] ipcomp: Convert struct xt_ipcomp spis into 16bits

On Mon, Jan 20, 2014 at 09:55:42AM +0800, Fan Du wrote:

On 2014年01月18日 20:24, Pablo Neira Ayuso wrote:

quoted

Didn't you find any way to fix this without change the layout of
xt_ipcomp?

My bad for not catching this in the initial ipcomp version.
It would be easier to just use ntohs here to ease sparse checking.


From dbf796e63d600256fd40000669b83227ddccebc4 Mon Sep 17 00:00:00 2001
From: Fan Du <redacted>
Date: Mon, 20 Jan 2014 09:42:12 +0800
Subject: [PATCHv2 net-next] ipcomp: Use ntohs to ease sparse warning

0-DAY kernel build testing backend reported:

sparse warnings: (new ones prefixed by >>)

quoted

quoted

quoted

quoted

net/netfilter/xt_ipcomp.c:63:26: sparse: restricted __be16 degrades to integer
net/netfilter/xt_ipcomp.c:63:26: sparse: cast to restricted __be32

Fix this by using ntohs without shifting.

Tested with: make C=1 CF=-D__CHECK_ENDIAN__

Applied to nf-next, thanks.