Re: [PATCH net-next 2/6] gianfar: Replace sysfs stubs with module params (fix)

From: Claudiu Manoil <redacted>
Date: Fri, 14 Feb 2014 14:04:01 +0200

Removing the sysfs stubs for the Tx FIFOCFG and ATTRELI
(stashing) config registers, as these registers may only
be configured after a MAC reset, with the controller stopped
(i.e. during hw init, at probe() time). The current sysfs
stubs allow on-the-fly updates of these registers (the locking
measures are useless and only add unecessary code).

Changing these registers on-the-fly is strogly discouraged.
In this regard, this patch may be seen as a security fix.

To address this issue and not lose entirely these config
params, they are now accessible as driver module parameters,
and their names and default values have been preserved.

Moreover, the stasing configuration options were effectively
disabled (didn't get to the hw anyway if changed) because
the stashing device_flags (HAS_BD_STASHING|HAS_BUF_STASHING)
were "accidentally" cleared during probe(). The patch fixes
this bug as well.

Signed-off-by: Claudiu Manoil <redacted>

Sorry, no new module parameters.

And as you state these never actually reached the hardware so they
_never worked_.  Please just remove them.