Re: [PATCH net-next v2 1/2] dts: Add a binding for Synopsys emac max-frame-size

Le mardi 14 janvier 2014, 09:57:36 Dinh Nguyen a écrit :

On Tue, 2014-01-14 at 08:40 -0600, Vince Bridgers wrote:

quoted

This change adds a parameter for the Synopsys 10/100/1000
stmmac Ethernet driver to configure the maximum frame
size supported by the EMAC driver. Synopsys allows the FIFO
sizes to be configured when the cores are built for a particular
device, but do not provide a way for the driver to read
information from the device about the maximum MTU size
supported as limited by the device's FIFO size.

Signed-off-by: Vince Bridgers <redacted>
---

 Documentation/devicetree/bindings/net/stmmac.txt |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/stmmac.txt

b/Documentation/devicetree/bindings/net/stmmac.txt index eba0e5e..26a0ba9
100644

--- a/Documentation/devicetree/bindings/net/stmmac.txt
+++ b/Documentation/devicetree/bindings/net/stmmac.txt

@@ -30,6 +30,10 @@ Required properties:
 Optional properties:
 - mac-address: 6 bytes, mac address

+- snps,max-frame-size:	Maximum frame size permitted. This parameter is

useful

I don't think max-frame-size should be a snps-only binding.

Right, and I already made that comment to Vince. Maybe this is just an 
oversight and mistakenly resubmitted v2 instead of v3?
-- 
Florian