Thread (21 messages) 21 messages, 2 authors, 2014-02-03

Re: [PATCH v2 4/6] can: sja1000: fuse of_platform into platform

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2014-01-31 12:51:25
Also in: linux-can, lkml

On 01/31/2014 01:49 PM, Marc Kleine-Budde wrote:
On 01/31/2014 01:45 PM, Florian Vaussard wrote:
quoted
Hello Marc,

On 01/31/2014 01:33 PM, Marc Kleine-Budde wrote:
quoted
On 01/31/2014 11:35 AM, Florian Vaussard wrote:
quoted
The OpenFirmware probe can be merged into the standard platform
probe to leverage common code.
Good work, as we want to replace the existing driver, I'm quite picky on
this patch, see more comments inline.

Please don't delete of of_platform driver, yet.
Do you have any reason for not deleting of_platform? After this patch,
we will have duplicated functionalities, this may be misleading for
other people.
Okay.
IIRC there _was_ a problem on sparc, it _should_ be fixed now, better
get a Tested-by from Andreas (Cc'ed).
You have to use irq_of_parse_and_map() on sparc, but your patches does this.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help