Re: Re: [PATCH RFC 4/6] net: rfkill: gpio: add device tree support

From
Chen-Yu Tsai <hidden>
Date
2014-01-29 04:02:07
Also in
linux-arm-kernel, linux-devicetree, linux-wireless, lkml
Reply to
Maxime Ripard, 2014-01-27
Hi,

On Mon, Jan 27, 2014 at 10:24 PM, Maxime Ripard
[off-list ref] wrote:
Hi,

On Fri, Jan 17, 2014 at 02:47:29PM +0800, Chen-Yu Tsai wrote:
quoted
Signed-off-by: Chen-Yu Tsai <redacted>
---
 .../devicetree/bindings/rfkill/rfkill-gpio.txt     | 26 ++++++++++++++++++++++
 net/rfkill/rfkill-gpio.c                           | 23 +++++++++++++++++++
 2 files changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt
diff --git a/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt b/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt
new file mode 100644
index 0000000..8a07ea4
--- /dev/null
+++ b/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt
@@ -0,0 +1,26 @@
+GPIO controlled RFKILL devices
+
+Required properties:
+- compatible : Must be "rfkill-gpio".
+- rfkill-name        : Name of RFKILL device
+- rfkill-type        : Type of RFKILL device: 1 for WiFi, 2 for BlueTooth
+- NAME_shutdown-gpios        : GPIO phandle to shutdown control
+                       (phandle must be the second)
Can't it be handled by a regulator?
quoted
+- NAME_reset-gpios   : GPIO phandle to reset control
And this one using the reset framework?
The driver is already used in platform device and ACPI fashions.
AFAIK, ACPI only passes the GPIO lines. Preferably the behavior
and requirements between the different usages remain the same.


Cheers
ChenYu
Thread (28 messages) 28 messages, 10 authors, last reply 2014-01-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help