Thread (33 messages) 33 messages, 8 authors, 2014-02-03

Re: [PATCH] netfilter: nf_conntrack: fix RCU race in nf_conntrack_find_get

From: Florian Westphal <fw@strlen.de>
Date: 2014-01-09 20:56:37
Also in: lkml, netfilter-devel

Andrew Vagin [off-list ref] wrote:
Can we allocate conntrack with zero ct_general.use and increment it at
the first time before inserting the conntrack into the hash table?
When conntrack is allocated it is attached exclusively to one skb.
It must be destroyed with skb, if it has not been confirmed, so we
don't need refcnt on this stage.

I found only one place, where a reference counter of unconfirmed
conntract can incremented. It's ctnetlink_dump_table().
What about skb_clone, etc?  They will also increment the refcnt
if a conntrack entry is attached to the skb.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help