Thread (25 messages) flat view 25 messages, 9 authors, 2014-01-17

Re: [PATCH 4/11] use ether_addr_equal_64bits

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2014-01-06 09:06:05
Also in: kernel-janitors, linux-wireless, lkml

On Tue, 2013-12-31 at 17:40 +0100, Julia Lawall wrote:
quoted
If nothing else, then some run-time code that calculates the offset off
and asserts if it is broken in module initialization or similar might
be good enough.
Could be OK.  Something right in or after the structure declaration would
be nicest.
I don't think you can put a BUILD_BUG_ON() into the structure
declaration (it's code, not declarations), but I think you could just
put

BUILD_BUG_ON(sizeof(struct foo) - offsetof(struct foo, addr) < 8);

with the user(s?) and that should catch the scenario I was worrying
about?

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help