Re: [PATCH net-next V4 3/3] net: Add GRO support for vxlan traffic

On Tue, Jan 14, 2014 at 11:47 PM, Or Gerlitz [off-list ref] wrote:

On Tue, Jan 14, 2014 at 7:59 PM, Tom Herbert [off-list ref] wrote:

quoted

On Tue, Jan 14, 2014 at 8:00 AM, Or Gerlitz [off-list ref] wrote:

quoted

Add GRO handlers for vxlann, by using the UDP GRO infrastructure.

[...]

quoted

quoted

 /* Notify netdevs that UDP port started listening */
-static void vxlan_notify_add_rx_port(struct sock *sk)
+static void vxlan_notify_add_rx_port(struct vxlan_sock *vs)
 {
        struct net_device *dev;
+       struct sock *sk = vs->sock->sk;
        struct net *net = sock_net(sk);
        sa_family_t sa_family = sk->sk_family;
        __be16 port = inet_sk(sk)->inet_sport;
+       int err;
+
+       if (sa_family == AF_INET) {

quoted

Is this necessary? What about support for AF_INET6?

Point taken -- the UDP GRO code for both ipv4 and ipv6 would work the same.

So we can export udp_gro_receive/complete from net/ipv4/udp_offload.c
such that they can be referred from net/ipv6/udp_offload.c

Hi Tom,

Spinning heads on this little more, it seems that the extension to IPv6 is
pretty much doable but needs little more work.  I would prefer it to
be carried out
incrementally once the basic concept + IPv4 support, is merged.
So posting V5 now with the RCU directives set by Eric fixed.

Or.