Thread (2 messages) flat view 2 messages, 2 authors, 2014-01-15

Re: [PATCH] ipv4: delete the statements limit icmp message in ip_error()

From: David Miller <davem@davemloft.net>
Date: 2014-01-15 01:04:59

From: Duan Jiong <redacted>
Date: Sun, 12 Jan 2014 17:52:20 +0800
Because after the icmp_send() is called, the icmpv4_xrlim_allow()
will be called to limit the icmp message too.

Signed-off-by: Duan Jiong <redacted>
icmpv4_xrlim_allow() is different from what this code is doing.

There are seperate controls for ip_error() reporting, namely:
-		if (peer->rate_tokens > ip_rt_error_burst)
 ...
-		if (peer->rate_tokens >= ip_rt_error_cost)
And this is the only place where that is taken into account.

The icmpv4_xrlim_allow() is a top level limiting on all ICMPs,
this function is limiting specific kinds.

I am not applying this patch, sorry.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help