Re: [PATCH net 0/2] tcp: delete redundant calls of tcp_mtup_init() and

From: Weiping Pan <redacted>
Date: Sun, 12 Jan 2014 15:54:29 +0800

I find that both tcp_v4_syn_recv_sock() and tcp_v6_syn_recv_sock() call them
for new sock, so delete redundant calls of them. 

Weiping Pan (2):
  tcp: delete redundant calls of tcp_mtup_init()
  tcp: delete redundant call of tcp_initialize_rcv_mss()

I do not agree with the approach of these two patches.

It is better to have tcp_rcv_state_process() (one location) make these
calls rather than each and every inet sock operations instance.

Therefore you should remove the calls from tcp_v{4,6}_recv_sock() and
keep the one in tcp_rcv_state_process().

Thanks.