Thread (25 messages) flat view 25 messages, 6 authors, 2014-01-15

Re: [PATCH 2/5] net: mvneta: use per_cpu stats to fix an SMP lock up

From: Willy Tarreau <w@1wt.eu>
Date: 2014-01-13 03:02:33

On Sun, Jan 12, 2014 at 04:45:03PM -0800, Eric Dumazet wrote:
On Sun, 2014-01-12 at 23:09 +0100, Willy Tarreau wrote:
quoted
But we can have multiple tx in parallel, one per queue. And it's only
when I explicitly bind two servers to two distinct CPU cores that I
can trigger the issue, which seems to confirm that this is the cause
of the issue.
So this driver has multiqueue ?
Yes, it defaults to 8 queues in each direction.
Definitely it should have one syncp per queue.

Or per cpu stats, as your patch did.
OK thank you for your review and explanation then, I'm reassured :-)

Thanks,
Willy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help