Thread (1 message) 1 message, 1 author, 2014-01-11

Re: [PATCH net,stable] net: usbnet: fix SG initialisation

From: Ming Lei <hidden>
Date: 2014-01-11 16:22:09

On Sat, Jan 11, 2014 at 5:16 PM, Ming Lei [off-list ref] wrote:
On Sat, Jan 11, 2014 at 6:10 AM, Bjørn Mork [off-list ref] wrote:
quoted
Commit 60e453a940ac ("USBNET: fix handling padding packet")
added an extra SG entry in case padding is necessary, but
failed to update the initialisation of the list. This can
cause list traversal to fall off the end of the list,
resulting in an oops.

Fixes: 60e453a940ac ("USBNET: fix handling padding packet")
Reported-by: Thomas Kear <redacted>
Cc: Ming Lei <redacted>
Signed-off-by: Bjørn Mork <redacted>
Tested-by: Ming Lei <redacted>

On one of my arm box, I can reproduce the problem with below
command every time:

                   $iperf -c $SRV -l 2398 -n 1 #the 2nd tcp packet
length is 1016

and the oops is same with Thomas's. After applying Oliver's patch,
I still can see zlp padding packet is appended, but no oops any more.

Thanks Oliver for fixing the problem.

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help