Re: [net-next v2 14/17] i40e: enable PTP

On Fri, 2014-01-10 at 20:37 +0000, Ben Hutchings wrote:

On Fri, 2014-01-10 at 12:30 -0800, Jeff Kirsher wrote:

quoted

From: Jacob Keller <jacob.e.keller@intel.com>

New feature: Enable PTP support in the i40e driver.

Change-ID: I6a8e799f582705191f9583afb1b9231a8db96cc8
Cc: Richard Cochran <richardcochran@gmail.com>
Cc: Ben Hutchings <redacted>
Signed-off-by: Matthew Vick <redacted>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Jesse Brandeburg <redacted>
Signed-off-by: Jeff Kirsher <redacted>
---
 drivers/net/ethernet/intel/Kconfig             |   1 +
 drivers/net/ethernet/intel/i40e/Makefile       |   1 +
 drivers/net/ethernet/intel/i40e/i40e.h         |  26 +
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c |  33 +-
 drivers/net/ethernet/intel/i40e/i40e_main.c    |  47 +-
 drivers/net/ethernet/intel/i40e/i40e_ptp.c     | 662 +++++++++++++++++++++++++
 drivers/net/ethernet/intel/i40e/i40e_txrx.c    |  53 ++
 drivers/net/ethernet/intel/i40e/i40e_txrx.h    |   3 +
 8 files changed, 824 insertions(+), 2 deletions(-)
 create mode 100644 drivers/net/ethernet/intel/i40e/i40e_ptp.c

diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/intel/Kconfig
index 9fb2eb8..333bb54 100644
--- a/drivers/net/ethernet/intel/Kconfig
+++ b/drivers/net/ethernet/intel/Kconfig

[...]

quoted

+void i40e_ptp_init(struct i40e_pf *pf)
+{
+	struct i40e_hw *hw = &pf->hw;
+	struct net_device *netdev = pf->vsi[pf->lan_vsi]->netdev;
+
+	strncpy(pf->ptp_caps.name, netdev->name, sizeof(pf->ptp_caps.name));

[...]

I recommended using the *driver* name as the clock name.  The net device
doesn't even have a proper name at this point.

Ben.

We use netdev->name a few lines farther down.. should that be changed as
well? Sorry about this one. The ixgbe driver initializes clock at open
instead of at init, so it has a valid clock name already.

Regards,
Jake