Re: [PATCH v2 net-next] net: make dev_set_mtu() honor notification return code

Fri, Jan 10, 2014 at 04:56:25PM CET, vfalico@redhat.com wrote:

Currently, after changing the MTU for a device, dev_set_mtu() calls
NETDEV_CHANGEMTU notification, however doesn't verify it's return code -
which can be NOTIFY_BAD - i.e. some of the net notifier blocks refused this
change, and continues nevertheless.

To fix this, verify the return code, and if it's an error - then revert the
MTU to the original one, notify again and pass the error code.

CC: Jiri Pirko <jiri@resnulli.us>
CC: "David S. Miller" <davem@davemloft.net>
CC: Eric Dumazet <edumazet@google.com>
CC: Alexander Duyck <redacted>
CC: Nicolas Dichtel <redacted>
Signed-off-by: Veaceslav Falico <redacted>

Reviewed-by: Jiri Pirko <jiri@resnulli.us>